Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative file links from index pages #746

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jun 28, 2023

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@cypress
Copy link

cypress bot commented Jun 28, 2023

3 failed and 1 flaky tests on run #849 ↗︎

3 70 0 0 Flakiness 1

Details:

Fix relative file links from index pages
Project: Collectives Commit: 9c8a4442b5
Status: Failed Duration: 07:50 💡
Started: Jun 29, 2023 1:55 PM Ended: Jun 29, 2023 2:03 PM
Failed  pages.spec.js • 1 failed test

View Output Video

Test Artifacts
Page > Creating a page from template > New page has template content Output Screenshots
Failed  apps.spec.js • 2 failed tests

View Output Video

Test Artifacts
The apps > Circles > shows circles in the contacts app Output Screenshots
The apps > Collectives > allows creating a new collective Output Screenshots
Flakiness  cypress/e2e/page-list.spec.js • 1 flaky test

View Output Video

Test Artifacts
Page list > Page trash > allows to trash and restore page with subpage and attachment Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

Signed-off-by: Jonas <jonas@freesources.org>
Fixes: #726

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/relative_link_from_indexpage branch from 50e547f to 9c8a444 Compare June 29, 2023 13:43
@mejo- mejo- merged commit 0546320 into main Jun 29, 2023
35 of 39 checks passed
@mejo- mejo- deleted the fix/relative_link_from_indexpage branch July 17, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to single top-level pages from README.md in folders are broken
2 participants